Discussion:
[Dnsmasq-discuss] [PATCH] Fix broken translations after commit 730c6745
Chris Novakovic
2017-07-17 17:53:40 UTC
Permalink
Commit 730c6745 makes a number of fixes to typos, among them the
messages reporting that asynchronous logging is unavailable in Solaris
and Android in src/dnsmasq.c. This is a gettext-localised string, and
the corresponding msgids in each of the translations weren't updated to
reflect the typo fixes, breaking these two translations for all
localisations.
This commit ports the typo fixes to the affected msgids in po/*.po,
fixing all translations for these strings.
I thought it'd be churlish of me to set myself as the Last-Translator
for each localisation, given that I didn't actually do any translating... :)
Simon Kelley
2017-09-25 16:23:55 UTC
Permalink
Patch applied, thanks

(and your name is in the git-log, even if it's not in the translation......)


Cheers,

Simon.
Post by Chris Novakovic
Commit 730c6745 makes a number of fixes to typos, among them the
messages reporting that asynchronous logging is unavailable in Solaris
and Android in src/dnsmasq.c. This is a gettext-localised string, and
the corresponding msgids in each of the translations weren't updated to
reflect the typo fixes, breaking these two translations for all
localisations.
This commit ports the typo fixes to the affected msgids in po/*.po,
fixing all translations for these strings.
I thought it'd be churlish of me to set myself as the Last-Translator
for each localisation, given that I didn't actually do any translating... :)
_______________________________________________
Dnsmasq-discuss mailing list
http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss
Josh Soref
2017-11-07 03:59:52 UTC
Permalink
Commit 730c6745 makes a number of fixes to typos, among them the
messages reporting that asynchronous logging is unavailable in Solaris
and Android in src/dnsmasq.c. This is a gettext-localised string, and
the corresponding msgids in each of the translations weren't updated to
reflect the typo fixes, breaking these two translations for all
localisations.
This commit ports the typo fixes to the affected msgids in po/*.po,
fixing all translations for these strings.
Thanks.

Everyone has different opinions about the right way to handle changes
to localizations.

It isn't terribly difficult for me to fix localizations when I fix the
sources, but some people complain about me stepping on the toes of the
localizers.
Because of that, for simplicity, I tend to delete localizations before
I run my pass to get potentially misspelled words (which means I don't
have to consider whether a word is a misspelling or just
French/Italian...) and leave the cleanup to the translation owners.

In general, someone is supposed to run msgmerge which should heal
translations broken by changes such as mine.

I think Simon did that in:
http://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=commit;h=30df7efc9654b080f763b78c2078ae13b51019c7
Loading...