Discussion:
[Dnsmasq-discuss] Spelling fixes for dnsmasq
Josh Soref
2017-02-02 06:43:39 UTC
Permalink
Hi...
I'm wondering if you'd be interested in any of these commits:
https://github.com/jsoref/dnsmasq/commits/spelling
https://github.com/jsoref/dnsmasq/compare/master...jsoref:spelling?expand=1

I could send a single diff for the changes, but I find that it's
usually best to let people think about changes individually, and it's
much easier for me to drop things when they're isolated commits than
after I've squashed them together.

144 misspelled word families;
47 files changed;
214 lines changed;

There are only a handful of changes to actual code:
dnsservers
errsave
ra_start_unsolicited

I understand that some pieces in the git repo are contrib/ including a
tarball with misspellings (contrib/webmin/dnsmasq.wbm). I can easily
drop more things, but I'd need guidance.
Neil Jerram
2017-02-02 08:54:57 UTC
Permalink
https://github.com/jsoref/dnsmasq/commit/56dc618b840dd893a65f02df2fb14752bb7ef33d is wrong; the word should be 'amended'.

  Original Message  
From: Josh Soref
Sent: Thursday, 2 February 2017 06:58
To: dnsmasq-***@lists.thekelleys.org.uk
Subject: [Dnsmasq-discuss] Spelling fixes for dnsmasq

Hi...
I'm wondering if you'd be interested in any of these commits:
https://github.com/jsoref/dnsmasq/commits/spelling
https://github.com/jsoref/dnsmasq/compare/master...jsoref:spelling?expand=1

I could send a single diff for the changes, but I find that it's
usually best to let people think about changes individually, and it's
much easier for me to drop things when they're isolated commits than
after I've squashed them together.

144 misspelled word families;
47 files changed;
214 lines changed;

There are only a handful of changes to actual code:
dnsservers
errsave
ra_start_unsolicited

I understand that some pieces in the git repo are contrib/ including a
tarball with misspellings (contrib/webmin/dnsmasq.wbm). I can easily
drop more things, but I'd need guidance.
Josh Soref
2017-02-02 09:03:11 UTC
Permalink
Post by Neil Jerram
https://github.com/jsoref/dnsmasq/commit/56dc618b840dd893a65f02df2fb14752bb7ef33d is wrong; the word should be 'amended'.
thanks. serves me right for occasionally doing things by hand instead
of always letting my browser suggest a correction.

updated.
Simon Kelley
2017-02-02 13:30:48 UTC
Permalink
Wow, what a lot of typos!

A couple of observations from a random sampling:

1) I don't want the code changes - if I missed vowels out of variable
names, I want them to stay missed out :)

2) I found two changes to proper names, Falempin and Murname. How did
you determine that those were (in)correct, and are there any more I
missed?

3) dnmasq is wrong.


Modulo that, and Neil's quible, I'd love to take this as a diff.


Cheers,

Simon.
Hi... I'm wondering if you'd be interested in any of these
commits: https://github.com/jsoref/dnsmasq/commits/spelling
https://github.com/jsoref/dnsmasq/compare/master...jsoref:spelling?exp
and=1
I could send a single diff for the changes, but I find that it's
usually best to let people think about changes individually, and
it's much easier for me to drop things when they're isolated
commits than after I've squashed them together.
144 misspelled word families; 47 files changed; 214 lines changed;
There are only a handful of changes to actual code: dnsservers
errsave ra_start_unsolicited
I understand that some pieces in the git repo are contrib/
including a tarball with misspellings (contrib/webmin/dnsmasq.wbm).
I can easily drop more things, but I'd need guidance.
_______________________________________________ Dnsmasq-discuss
http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss
Jim Alles
2017-02-02 17:05:03 UTC
Permalink
Careful, we could have a fatal recursion:

quible is speeled wrong.

(smiley face)

.ja.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Wow, what a lot of typos!
​...​
Modulo that, and Neil's quible, I'd love to take this as a diff.
Simon Kelley
2017-02-02 17:25:19 UTC
Permalink
This may explain the Entire State of the World Today.

Simon.
Post by Jim Alles
quible is speeled wrong.
(smiley face)
.ja.
On Thu, Feb 2, 2017 at 8:30 AM, Simon Kelley
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256
Wow, what a lot of typos! ​...​
Modulo that, and Neil's quible, I'd love to take this as a diff.
Shantanu Gadgil
2017-02-02 18:48:44 UTC
Permalink
Post by Simon Kelley
Modulo that, and Neil's quible, I'd love to take this as a diff.
That's what she said ?!?
Simon Kelley
2017-02-06 16:20:00 UTC
Permalink
Patch applied, many thanks for that.

(I'll reject the message containing the patch from the mailing list,
to save all the subcribers from a 110K message. If they want to see
what was in it, they can look in the git repo now.)


Cheers,

Simon.


On 05/02/17 14:13, Josh Soref wrote:
Loading...